Skip to content

Turn translation completion tooltips into full sentences

GunChleoc requested to merge 12-completion-percentage-translation into main

I am using ngettext to fetch the strings with numbers in them. xgettext will extract them properly, but I can't test the translations because of #15.

The following tests still need to be performed:

  1. Check all 4 variations of the tooltips (website/comics complete/incomplete)
  2. msgmerge and translate a language to see if ngettext will fetch the translations

If 2 fails, the third to last commit ("Use ngettext to fetch percentage numbers") can be split off into a separate branch for future fixing.

Technical notes:

  • By using single quotes around the translatable strings rather than double quotes, PHP will skip parsing the string contents, so we don't need to escape the $ signs. It's also faster.
  • For removing commits, it's probably easiest to create a new branch and use git cherry-pick.

Closes #12 (closed)

Edited by GunChleoc

Merge request reports