Draft: Renderfarm refactor
Goals
goals and rationale are described in this merge request's corresponding issue.
Script code review
Some scripts are merged/modified versions of files found in peppercarrot/webcomics/0_transcripts. This is mostly done to be able to generate a single specific file (needed for make
) and loosen the dependency between peppercarrot/webcomics and peppercarrot/tools.
-
md_to_html_transcript.py is a merged and specialized version of 0_transcripts/extract_to_html.py and 0_transcripts/markdown.py to generate a single HTML transcript page from a md transcript file.
-
titles_json_generator.py is a merged and specialized version of 0_transcripts/collect_titles.py and 0_transcripts/svg.py to generate a single titles.json file.
They are sometime heavily modified and I was not extremely familiar with xml.etree
. I tested them and they should be bug free but having someone else check these file would be best.
Since you are the author of the original files, could you do a review @gunchleoc ? If you have time of course. Also, could you check that the copyright headers are fine with you?
Makefile authorship
Since the makefile is a recreation of the old renderfarm.sh in a Makefile form, I have credited the previously credited authors (@Deevad and mjtalkiewicz) as author of the Makefile.
Integration tests
The latest version of renderfarm should be tested in a live context. @Deevad could you check the newest changes correspond to your needs and don't break earlier features?