Skip to content

Draft: Renderfarm refactor

Christian Aribaud requested to merge renderfarm-refactor into master

Goals

goals and rationale are described in this merge request's corresponding issue.

Script code review

Some scripts are merged/modified versions of files found in peppercarrot/webcomics/0_transcripts. This is mostly done to be able to generate a single specific file (needed for make) and loosen the dependency between peppercarrot/webcomics and peppercarrot/tools.

They are sometime heavily modified and I was not extremely familiar with xml.etree. I tested them and they should be bug free but having someone else check these file would be best.

Since you are the author of the original files, could you do a review @gunchleoc ? If you have time of course. Also, could you check that the copyright headers are fine with you?

Makefile authorship

Since the makefile is a recreation of the old renderfarm.sh in a Makefile form, I have credited the previously credited authors (@Deevad and mjtalkiewicz) as author of the Makefile.

Integration tests

The latest version of renderfarm should be tested in a live context. @Deevad could you check the newest changes correspond to your needs and don't break earlier features?

Edited by Christian Aribaud

Merge request reports