Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • YWD Nova Translatable YWD Nova Translatable
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 4
    • Issues 4
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • yeswedevyeswedev
  • YWD Nova TranslatableYWD Nova Translatable
  • Merge requests
  • !2

refactor translatable class for better performance

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Bobby Borisov requested to merge borisov/ywd_nova-translatable:master into master Jan 02, 2019
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 1

Hey guys, I am proposing a change in resolves method because I saw you query the database for each translation, i simplified the code to do just pluck. That way I managed to reduce speed by 2x.

Let me know if you have any concerns about merging this Merge Request

Cheers!

Edited Jan 02, 2019 by Bobby Borisov
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master