Fields for sharing form results not where they should be
Not actually a bug, but something doesn't seem quite logical in the code structure. When sharing a form (either publicly - everyone has access to results - or selectively - selected users have access to results) :
- the access rights and additional behaviors for the results sharing are located inside the
framaforms_public_results
andframaforms_share_results
, respectively. - the actual fields related to sharing are actually defined in the
form1
fields withinframaforms
.
The effect of this is that both modules are not fully independent : even if the site's admin doesn't activate these modules, the fields are still visible to users creating new forms, but the features behind these are not available, which can be confusing.
This would require some work, but one of the following could be implemented for a more logical code structure :
- alter the
form1
node type to add fields from within the additional sharing modules : add new fields to the node type on module install. This seems quite tedious, and would also require deleting these fields on module uninstall. - simply hook the
form1
creation form andsubmit
callback from within these modules to add the information to a new set of tables. This is probably the easiest way to go about it.