Release a first working version
This issue is used to detail the current status of development of the add-on.
Current status
The add-on compiles successfully on macOS and Linux (tested only on RPi3+OSMC). Check doc/building.md for more information.
Note for macOS
For some reason when compiling on macOS, the value of the `platform` attribute in `/build/addons/vfs.libtorrent/addon.xml` is `osx-` instead of `osx-x86_64` which prevents the add-on from being activated in Kodi. The workaround is to run this command after build:sed -i '' -e 's/osx-<\/platform>/osx-x86_64<\/platform>/' <kodi-source-code-path>/build/addons/vfs.libtorrent/addon.xml
Nevertheless some workarounds in CMake files were required : see 3b07f1b2 and ca3ea830 for more information about the workarounds. They should be fixed/improved at some point.
The add-does not compile on Windows currently (work in progress).
To try out the add-on you may use:
- the branch leia and the branch changes-for-vfs-libtorrent of the PeerTube add-on on Kodi 18 (was tested only on Kodi 18.9)
- the branch matrix and the branch vfs-libtorrent-plus-matrix of the PeerTube add-on on Kodi 19
The add-on works as expected (i.e. torrents are downloaded, paused and resumed) and is in final testing stage but Kodi crashes randomly quite often and it is very likely due to this add-on.
When checking the system logs, they are some libtorrent’s assert failures but nothing obvious to fix.
Some ideas:
- Incompatibility between libtorrent multi threading and how Kodi manages add-ons in the background?
- Try to compile libtorrent with more debug logging to have more information about the crashes
- Try to upgrade libtorrent (to 1.2 or to 2.x), maybe some bugs that were fixed will help with the crashes
- Request support to the libtorrent team
Next steps
- Fix the random crashes issue
- Release a beta version and ask some users to test it
- Fix compilation on Windows
- Release a version in Kodi official repo