Skip to content

Plural markup

GunChleoc requested to merge plural-markup into main
  • Correct plural markup for all strings with numbers. Note that I am using %d for numbers always, this makes it clear to translators that it's a number, preventing translation mistakes.
  • I also fixed a small English error in the en.po file. If you fix tiny errors that don't change the meaning there, it will preserve the translations already done. If there is a meaning change, or the change makes the English source easier to understand, change it in the source code instead - a missing translation is better than a wrong translation.

And another side note: When doing ngettext markup, the singular and plural strings should always be identical except for plural endings. I have broken hat rule with the "all" keyword, since we don't expect the number 1 to turn up here. My language fetches 1 and 11 with the same rule - never make any assumptions about what other languages do when you prepare a plural string.

If you introduce new strings in the future, feel free to tag me for review if you want.

Merge request reports