Skip to content

Draft: Adding the option to define custom time periods

Simón Torres requested to merge simontorres/l1p5-vuejs:noirlab_v1 into noirlab_v1

This merge request implements the option to enter different type of time periods. In summary there are three options

This does not yet compute the GHGI report using these new defined boundaries.

  1. Calendar Year
  2. Fiscal Year - US (starts October 1st of Year - 1 and ends in September 30th)
  3. Custom (Allows to enter random dates as start or end)

It would look like this:

image

As of the moment of creating this merge request, some of the things that need to be done are:

  • Translation to French for the file homefs/src/components/carbon/forms/Boundaries.vue
  • Define whether random time periods should be of exactly one year long or any length is fine.
  • Add a constraint that the start date should be earlier than end date
  • I would like to discuss with the French team whether my changes are in accordance with their style guide. I tried to mimic it but I want to make sure.
  • Clean the commit history
Edited by Simón Torres

Merge request reports