Skip to content

Don't connect menu signal multiple times.

FeRD (Frank Dana) requested to merge ferdnyc/recoll:menu-triggered into master

Another issue that GammaRay spotted: The triggered signal of the m_filtMN menu was being connected to its catgFilter slot inside the loop that adds category-selection QActions to it. Meaning it was connected multiple times: once for each category in the menu (except "All").

The signal/slot overloads of triggered being used include a QAction* pointer to the specific menu action that was selected, so it should only be connected once to represent all of the menu selections.

Merge request reports