Skip to content

Collection: fix _delete

Matt requested to merge dev/fix-travels into master

The previous implementation was wrong. Splicing the array shifts all the subsequent indexes. Thus this actually lead to two bad situations:

  1. the removal of correct items
  2. the non deletion of wanted indexes

In the new implementation we null the entry of this.items to be deleted and finally we filter out them.

Merge request reports