Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • kresus kresus
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 143
    • Issues 143
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • kresusapp
  • kresuskresus
  • Merge requests
  • !588

Fix skins

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nicolas Frandeboeuf requested to merge nicofrand/kresus:fix-skins into master Dec 05, 2017
  • Overview 4
  • Commits 3
  • Pipelines 4
  • Changes 5

I am really sorry, I did not catch those two errors during my final tests of the theme MR. The first one is that loading errors were actually throwing a JS error when trying to check if the theme that failed to load was the default one…

The second is that Chrome won't always fire an onload/onerror event on the link tag (it does the first time). I don't know why, I'll keep digging but meanwhile the only solution I found was to implement a fallback timer : if after 30 seconds the component has been updated, nothing has been fired, we check for it manually.

Edited Dec 06, 2017 by Nicolas Frandeboeuf
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-skins