Skip to content

Make Dockerfiles great again

Benjamin Bouvier requested to merge docker into master

Dockerfile-stable can be tested with the prebuilt image bnjbvr/kresus-beta. The command line to start it will look like this:

docker run -ti -v /path/to/data:/home/user/data -v /tmp/weboob:/weboob -p 9876:9876 bnjbvr/kresus-beta

It is much easier to handle (it will just do npm install -g kresus, which btw I think is broken at the moment without the chown fix in /usr/local/lib/node_modules/kresus). At startup, the image will try to:

  • git clone or git pull weboob
  • install new weboob pip dependencies
  • try to update the globally installed kresus
  • change UID / rights to the data volume so that it always works (this fixes #575 (closed))

With this new Docker image, weboob can be:

  • shared among different Docker instances of the kresus image
  • updated from outside the Docker image, once in a while
  • updated on every instance restart

Of course, I'll change the Makefile rule (to build the bnjbvr/kresus image instead of kresus-beta) and will update docs. Happy to get some feedback from @nicofrand and @ZeHiro, to make sure it works; if it does, I'll probably merge tomorrow / today.

Merge request reports