Skip to content

Use the default value for 'weboob-version' cached value. Fixes several TS errors.

Antoine requested to merge ZeHiro/kresus:weboob-version into master

This MR fixes the following TS errors by making the cachedWeboobVersion null when it is unset or fetching the version failed:

server/controllers/v1/settings.js:52:56 - error TS2345: Argument of type 'number' is not assignable to parameter of type 'string | null'.
52                 isInstalled: checkWeboobMinimalVersion(version)

server/lib/sources/weboob.js:204:36 - error TS2345: Argument of type 'number' is not assignable to parameter of type 'string | null'.
204         !checkWeboobMinimalVersion(cachedWeboobVersion) ||

server/lib/sources/weboob.js:209:17 - error TS2367: This condition will always return 'false' since the types 'number' and 'string' have no overlap.
209             if (cachedWeboobVersion === '?') {

@nicofrand Can you check that the update of the weboob-version in the client works the same as in your initial design ?

Merge request reports