Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • kresus kresus
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 142
    • Issues 142
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 6
    • Merge requests 6
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • kresusapp
  • kresuskresus
  • Issues
  • #1035
Closed
Open
Created Nov 05, 2020 by Nicolas Delebecque@nicodel

Replace modals by alternative solutions

The idea is to remove the dependency to react-modal by using specific pages or popovers.

Depending on the action required, the context in which the action is required, the amount on explaination necessary, the amount of fields to complete... 3 alternatives could be used:

  • ui/popover: a component to display a simple confirm or cancel choice to user.
  • ui/popform: a component to display a form over the current page.
  • ui/form-row: a component to display a form inside a page.

Here is a list of modals currently used in Kresus, and proposed alternatives:

  • accesses/disable-access-modal: Requests user confirmation that he wants to disable the account. => ui/popover !1330 (merged)
  • accesses/edit-access-modal: Change login and password for a bank account. => ui/pop-row !1330 (merged)
  • charts/default-params-modal: Change the default parameters of charts display. => ui/pop-row !1337 (closed)
  • operations/add-operation-modal: Add an operation to the current bank account. => ui/form-row : @ZeHiro
  • operations/details: Modify an operation custom label, category, type, monthly budget, and delete the operation. => ui/form-row: !1372 (merged)
  • emails/alert-form-modal: Add an email alert by specifying the bank account, the limit and the value (for balance or transaction amount). => ui/form-row
  • emails/report-form-modal:Add a schedule report to be send by email at a chosen frequency. => ui/form-row
  • emails/confirm-delete-modal: Request user confirmation that he wants to remove a email alert. => ui/popover
Edited Dec 29, 2020 by Antoine
Assignee
Assign to
Time tracking