Skip to content

ACL dialogs: Make the non-ACL-option description more accurate

Mario requested to merge Treer:permissions into dev

Created by: Treer

hubzilla permissions dialog2

It could still do with better ideas than mine for theming/layout/icon choices, but this code gets the information into the ACL dialog.

The ACL dialog is fully backwards compatible, but you can pass it a higher-level permissions description if desired.

I've updated the populate_acl() calls in the following modules with what an empty-ACL means:

  • Photos.php (view_storage)
  • Rpost.php (view_stream)
  • Network.php (view_stream)
  • Webpages.php (view_pages)
  • Filestorage.php (view_storage)
  • Editwebpage.php (view_pages)
  • Channel.php (view_stream)
  • Events.php (view_stream - because Cal.php is what displays these and it has a comment saying "since we don't currently have an event permission - use the stream permission")
  • Settings.php (displays the string "Use my default audience setting for the type of channel")

But it's not always clear to me how an empty ACL is going to be interpretted by Hubzilla, so for now I've left the following the way they were:

  • Chat.php
  • Mitem.php
  • Display.php (I think this falls back to public, so populate_acl() should be called with \PermissionDescription::fromStandalonePermission(PERMS_PUBLIC), but I'm not certain)
  • Thing.php

I wasn't sure if PermissionDescription was supposed to be a Zotlabs module, it's a class, but it has no use outside of include\acl_selectors.php. If there's a refactoring move happening from include -> Zotlabs I may have just made more work.

Merge request reports