Skip to content

Cleanup unit tests

Harald Eilertsen requested to merge snake66/hubzilla-core:tests/cleanup-unit-tests into dev

Enabled some tests that were not run, and removed some test cases that have no value (testing builtin PHP functions etc.) Apart from that mostly cosmetic changes.

Some tests are left disabled for now:

  • tests/unit/expand_acl_test.php: The tests and the implementation does not agree on what's an acceptable input for the function, and I wasn't able to find any documentation to clarify which of them was right. The test assumes that only numeric values are acceptable, while the implementation will accept pretty much anything.
  • tests/unit/template_test.php: This pretty much tests the Smarty3 library, not the Hubzilla templating code (which is just a very thin wrapper.) It's also a bit tricky to test, and the value is low if any at all. I suggest we just drop this one.

Merge request reports