Remove warnings
I try to remove all warnings, there are some that are still here:
-
The ones for documentation over a private function (you can read about it here: https://stackoverflow.com/a/45174822)
-
Some unused functions
There are two things that seems problematic to me in the warnings :
warning: invalid association tags
in schema Pickweaver.Stories.Story: associated schema Pickweaver.Stories.Tag does not have field story_id
lib/pickweaver/stories/story.ex:1: Pickweaver.Stories.Story (module)
warning: function Pickweaver.Services.Parser.Tweet.parse_single_url/1 is undefined or private. Did you mean one of: * parse_single_url/2 lib/pickweaver/services/parse.ex:20 warning: function Pickweaver.Services.Parser.Tweet.parse_twitter_url_list/1 is undefined or private. Did you mean one of: * parse_twitter_url_list/2 lib/pickweaver/services/parse.ex:21
The amount of other warnings were hiding these important ones.
There's still one error in the tests that I didn't fix, because I don't know what to do with it one this test list_stories_for_account_slug/2
you are only retrieving the stories that are published and you return all the stories in list_stories_for_account_id/2
.
Hope this PR will help.