Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • PeerTube PeerTube
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • FramasoftFramasoft
  • PeerTubePeerTube
  • PeerTubePeerTube
  • Merge requests
  • !32

Return result of onLogout

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Louis requested to merge artonge/PeerTube:feature/logoutUrlForAuthProviders into develop Nov 13, 2020
  • Overview 9
  • Commits 8
  • Pipelines 0
  • Changes 8

The auth-saml plugin would benefit from supporting a full logout process.

Use case:

  • The user logout from peertube
  • The auth-saml plugin craft a logoutUrl that the user must visit to complete its logout process
  • The server respond to the client with that logoutUrl as redirectUrl
  • The client redirect the user to the redirectUrl

This MR contains the following changes:

  • Give access to the request during the onLogout call
  • Use the return value of the onLogout method of an auth provider as the redirectUrl
  • Forward the logoutUrl to the client in the revoke-token response
  • The client redirect the user to the logoutUrl if it is exists
Edited Nov 18, 2020 by Louis
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/logoutUrlForAuthProviders