Skip to content
  • Micah Elizabeth Scott's avatar
    Remove hard-coded 8GB upload limit in client (#1293) · 4b493858
    Micah Elizabeth Scott authored and Chocobozzz's avatar Chocobozzz committed
    * Remove hard-coded 8GB upload limit in client
    
    Ideally we'd know what the specific server's configured upload limit
    is before starting, but this 8GB limit is not useful if an administrator
    has changed the nginx post limit on the server.
    
    * Better docs for admins about client_max_body_size
    
    Seems like some admins already tweak this value up or down to allow
    for different maximum video upload sizes. The current codebase has no
    other server-side limits that I'm aware of, and I've been routinely
    uploading quite large videos to my instance.
    
    This patch replaces the somewhat incorrect (or outdated?) 'hard limit'
    comment with some advice about allocating enough space for nginx and
    communicating the limit with your users.
    
    Of course it would be better if this configuration could be unified with
    PeerTube's config somehow. I'm not sure whether the best option there is
    to turn off nginx's buffering here and let PeerTube handle the entire upload
    (can we do this only for the video upload API endpoint?) or whether we want
    PeerTube to generate nginx configs in a more automated way layer. In any case,
    this patch is intended as an incremental improvement.
    4b493858