Skip to content

chore: improvements

Congratulations on this excellent app!

Here are some improvements for evaluation. Sorry for the rather large merge request but I didn't find a way to do it in small parts.

I identified that the app was making many requests that could be replaced by the initial state feature. I made these substitutions to achieve better performance when the app initially loads.

I made it easier to create a new Intros for an app now using Events. The way I implemented it, it is now possible for any app to manage its own Intros and Intros texts can be sent to the translation platform used as it is now possible to use Nextcloud's translation function.

The file lib/Listener/FetchIntrosListener.php could be more clean if we implement this new way to write an Intros. I also can do this at this merge request if you like.

I did not make changes to the documentation before awaiting consideration from the project maintainer. If it is OK to merge these improvements, then I implement the updates to the documentation.

There are some other points of improvement in the app but we can improve these in the next steps.

Below is an example of implementing Intros in an app using the resources of the refactor made.

https://github.com/LibreSign/libresign/pull/3332

Edited by Vitor Mattos

Merge request reports