Skip to content

Add changeset_comment in JOSM remote command load_and_zoom

Binnette requested to merge (removed):changeset-comment into develop

Hi Adrien, here is a first version.

It is working nicely but not as I expect. I was thinking that it was possible to ask JOSM to set the property "hashtags" of a changeset. But it is not possible (see JOSM remote control args). So I choose to do the only thing possible: set a default comment by using parameter 'changeset_comment'. I test my code and it works (comment is set in JOSM).

Other questions:

  1. I choose to store the tag "#Pic4Review" in file "constant.js". Do you agree ?
  2. Also, i have to escape # with %23. Should i write "#Pic4review" in "constant.js" and then encode this property in the source code ?
  3. I think, i'm gonna add a 'if' to check if that constant is not null before concatenate to JOSM url. Do you agree ?

Please review my code, so i can correct it and re-submit this PR.

Merge request reports