cannot download releases where the name ends with a period when running on Windows
Windows does not allow directory names to end with a period.
When the downloader attempts to create a directory for a release name that ends with a period, Windows silently discards the trailing period(s) and creates the directory. Then the downloader fails with a NullPointerException when it tries to download into the original name because that directory does not exist.
Example logs of the failure:
[pool-1-thread-4] Starting the download of "In Memory Of..." (2013) by Various Artists.
[pool-1-thread-4] Error while trying: "java.lang.NullPointerException: null".
[pool-1-thread-4] Retrying (1/3).
[pool-1-thread-4] Error while trying: "java.lang.NullPointerException: null".
[pool-1-thread-4] Retrying (2/3).
[pool-1-thread-4] Error while trying: "java.lang.NullPointerException: null".
[pool-1-thread-4] Retrying (3/3).
[pool-1-thread-4] Error while trying: "java.lang.NullPointerException: null".
[pool-1-thread-4] Could not download item: Could not perform task after 3 retries.
Example bandcamp releases that reproduce this issue:
"For the Record..." (2020) by Bart Graft (Bandcamp ID: r132070567)
https://music.businesscasual.biz/album/for-the-record
"In Memory of..." (2017) by TWAYNG McGRAW (Bandcamp ID: r144631982) https://boguscollective.bandcamp.com/album/in-memory-of
"In Memory Of..." (2013) by Various Artists (Bandcamp ID: r137915894) https://auralfilms.bandcamp.com/album/in-memory-of
"It pours..." (2019) by TRVSHBXVT (Bandcamp ID: r144632116) https://boguscollective.bandcamp.com/album/it-pours
"Nothing can be done..." (2016) by ?liquid_architect? (Bandcamp ID: r144631663) https://boguscollective.bandcamp.com/album/nothing-can-be-done
"The Word is..." (2015) by HuDost & Steve Kilbey (Bandcamp ID: p21585416) https://hudost.bandcamp.com/album/the-word-is
"This Is The Water..." (2017) by Jack Hertz (Bandcamp ID: r137915823) https://auralfilms.bandcamp.com/album/this-is-the-water
"." (2017) by 【事業】BLADE RUNNER (Bandcamp ID: r236506252) https://projectbladerunner.bandcamp.com/album/--16