Commit 4ee945db authored by yPhil's avatar yPhil
Browse files

Feedprefs slider handles

- In the feedPrefs dialog both hight & nBItems slider handle texts were not refreshed when their value was changed using the spinner buttons
- Doc update
- Libs update
  - Feedrat false positives, if not killed entirely at least reduced
parent f856ba9e
Pipeline #435873 passed with stage
in 1 minute and 43 seconds
# Changelog
## 1.4.0
## 1.4.2
- New "media" paradigm in the feed preferences #a633d06d
- Text only mode don't show anything but text
- Text only mode now really shows only text
- New help tour : Menu entries #5884a8b
- Column buttons now appear on hover #cf906bb
- Video embeds in help tour popups
- Video embeds (locale'd, well at least En & Fr) in help tour popups
- Graceful handling (on-screen text) of various disabled features : JS, DOM storage
### Bugfixes
- In the feedPrefs dialog both hight & nBItems slider handle texts were not refreshed when their value was changed using the spinner buttons
- Proper URL construction when building the bookmarklet to avoid catching anything but protocol + domain
- Removed isQueryString bool, added isNewFeed bool
- Refresh icon tooltip text (both feed URL / name and timeStamp) were `undefined` after a (long) while #a633d06d
- Refresh icon tooltip text items (both feed URL / name and timeStamp) were `undefined` after a (long) while #a633d06d
## 1.3.3
......
......@@ -45,7 +45,7 @@ Pétrolette is fully self-contained, makes **no external call** whatsoever, and
Read [the changelog](https://framagit.org/yphil/petrolette/-/blob/master/CHANGELOG.md).
### Installation
### Install
```sh
git clone https://framagit.org/yphil/petrolette
......@@ -53,9 +53,15 @@ cd petrolette
npm install
npm start
xdg-open http://localhost:8000
```
#### Test
```sh
cd petrolette
git pull
npm update
```
#### Testing
#### Test
```javascript
npm test
......
This diff is collapsed.
{
"name": "petrolette",
"description": "The news reader that doesn't know you",
"version": "v1.4.1",
"version": "v1.4.3",
"private": true,
"license": "GPL-3.0-only",
"HTTP_PORT": 8000,
......@@ -40,12 +40,12 @@
"idb": "^6.0.0",
"morgan": "^1.10.0",
"node-fetch": "^2.6.1",
"npm": "^7.10.0",
"npm": "^7.20.1",
"pm2": "^5.1.0",
"sanitize": "^2.1.0"
},
"devDependencies": {
"mocha": "^9.0.0",
"mocha": "^9.0.3",
"nyc": "^15.1.0",
"should": "^13.2.3"
}
......
......@@ -445,7 +445,7 @@ PTL.dialog = {
.spinner('value', oldLimit)
.on('spinstop', function() {
$feedLimitSlider.slider('option', 'value', $(this).val());
$dialog.find('div#feedNbItemsSpinner > .ui-slider-handle').text($(this).val());
$dialog.find('div#feedLimitSlider > .ui-slider-handle').text($(this).val());
});
$feedLimitSlider.slider({
......@@ -473,7 +473,7 @@ PTL.dialog = {
.spinner('value', oldNbItems)
.on('spinstop', function() {
$feedNbItemsSlider.slider('option', 'value', $(this).val());
$feedNbItemsSliderHandle.text($(this).val());
$dialog.find('div#feedNbItemsSlider > .ui-slider-handle').text($(this).val());
});
$feedNbItemsSlider.slider({
......
......@@ -15,30 +15,31 @@
</div>
<div id="feed-prefs">
<form>
<legend data-content="Location"
class="ui-corner-top translate">Location</legend>
<fieldset id="locationFieldset">
<div id="feedGuessDiv"
class="flexBox helpTourDialogItem"
data-step="1">
<input name="guess"
id="feedGuessInput"
placeholder="https://xkcd.com/rss.xml or https://xkcd.com + SEARCH"
data-title="Enter a website address/URL and click search, then OK, or simply enter the URL of the feed and click OK"
value=""
onclick="this.select()"
class="grow translate"
/>
<button id="feedGuessButton"
data-title="Find / discover the feed of this website, or build a search feed from the words"
class="shrink translate last"
type="button">
<i class="icon-search"></i>
</button>
</div>
</fieldset>
<legend data-content="Location"
class="ui-corner-top translate">Location</legend>
<fieldset id="locationFieldset">
<div id="feedGuessDiv"
class="flexBox helpTourDialogItem"
data-step="1">
<input name="guess"
id="feedGuessInput"
placeholder="https://xkcd.com/rss.xml or https://xkcd.com + SEARCH"
data-title="Enter a website address/URL and click search, then OK, or simply enter the URL of the feed and click OK"
value=""
onclick="this.select()"
class="grow translate"
/>
<button id="feedGuessButton"
data-title="Find / discover the feed of this website, or build a search feed from the words"
class="shrink translate last"
type="button">
<i class="icon-search"></i>
</button>
</div>
</fieldset>
<div id="advanced">
<legend data-content="Name"
class="ui-corner-top translate">Name</legend>
<fieldset id="nameFieldset">
......@@ -162,8 +163,8 @@
</div>
</fieldset>
</div>
</form>
</div>
<div id="helpDialog" title="Pétrolette">
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment