I tried your MR code in Kresus docker image. It works with few changes I shared it in Woob MR discussion thread
On 25 Aug 2023, at 2:46 PM, Nicolas Frandeboeuf (@nicofrand) gitlab@framasoft.org wrote:
Nicolas Frandeboeuf commented on a discussion:
Would you be so kind to check https://gitlab.com/woob/woob/-/merge_requests/842 please, regarding the woob part? I simply copied your old code in the new classes…
— Reply to this email directly or view it on GitLab. You're receiving this email because of your account on framagit.org. Unsubscribe from this thread · Manage all notifications · Help
I’ll try to spend some time this weekend but I don’t have anymore an Amex account so I don’t know if it’s going to be fruitful
Not 100% sure but there is high chances I was using a customised container using TINI.
On 24 Aug 2023, at 8:32 PM, Nicolas Frandeboeuf (@nicofrand) gitlab@framasoft.org wrote:
Nicolas Frandeboeuf commented:
I am kinda confused by this…
A merge request to fix this (with the code above) was opened 3 years ago by @sinopsysHK (https://gitlab.com/woob/woob/-/merge_requests/444) and closed because “BTW, the americanexpress module does not use selenium anymore”. But the code seems to disagree: https://gitlab.com/woob/woob/-/blob/master/modules/americanexpress/browser.py?ref_type=heads#L498.
But it seems it was put again in https://gitlab.com/woob/woob/-/commit/fd94d5c081d9550f0d1ee316fdc0bd17242aa291.
I'll ask if this should be reopened.
@sinopsysHK When you said "I just tested on the kresus container and it works as well" you meant without editing the docker image/entrypoint to use "TINI"? ie. that's a woob issue only?
— Reply to this email directly or view it on GitLab. You're receiving this email because you have been mentioned on framagit.org. Unsubscribe from this thread · Manage all notifications · Help
Hello,
what do you think about generalizing the "withCurrentAccountId" applied on Operations and Charts page and using "withDriver" that could then be either:
The idea is that the driver will be in charge to provide the different required data for both pages (Operations & charts) such as:
This will be an enabler for using views as defined in #734
Let me know if this could fit in your plans and if so I could start something of this kind.
Closed with !1377 (merged)
Implementation proposal (version 3.12) with MR !1560 (merged)
Adapt to new interface of typeormi (breaking changes), removing deprecated objects/methods call
Fix migrations issues which could lead to data loss when some table structures are changed using sqlite.
Fixes #1164.
sinopsysHK (b0ef87df) at 18 Apr 14:17
Upgrade typeorm to 3.12
sinopsysHK (46641fb0) at 18 Apr 13:59
Adapt to new interface of typeorm
sinopsysHK (79bc3498) at 21 Feb 23:55
Adapt to new interface of typeorm
sinopsysHK (8e6e76f2) at 17 Feb 00:08
Link pie chart and bar charts clicked categories together
... and 6 more commits
sinopsysHK (b427795a) at 31 Jan 12:57
remove deprecated objects/methods call
typeorm has fixed many of the sqlite related issues with recent versions (including support of table altering with linked foreign keys).
Upgrading to more recent version (0.3.11 vs 0.2.39) would make sqlite based setups more reliable.
sinopsysHK (8cbf0418) at 29 Jan 02:01
[client] Add shortcut in transaction details to create a recurring ...
... and 4 more commits