Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
S
simgrid
Project overview
Project overview
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
10
Issues
10
List
Boards
Labels
Milestones
Merge Requests
2
Merge Requests
2
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
simgrid
simgrid
Commits
23eddc1d
Commit
23eddc1d
authored
Dec 02, 2019
by
Augustin Degomme
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix issue with copy avoidance, which was merely working by accident in most cases.
That was causing HPL to loop.
parent
cddf2ac3
Pipeline
#192611
passed with stages
in 21 minutes and 24 seconds
Changes
1
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
2 deletions
+2
-2
src/smpi/internals/smpi_global.cpp
src/smpi/internals/smpi_global.cpp
+2
-2
No files found.
src/smpi/internals/smpi_global.cpp
View file @
23eddc1d
...
...
@@ -179,7 +179,7 @@ void smpi_comm_copy_buffer_callback(simgrid::kernel::activity::CommImpl* comm, v
XBT_DEBUG
(
"Copy the data over"
);
if
(
smpi_is_shared
(
buff
,
src_private_blocks
,
&
src_offset
))
{
src_private_blocks
=
shift_and_frame_private_blocks
(
src_private_blocks
,
src_offset
,
buff_size
);
if
(
src_private_blocks
.
size
()
==
1
&&
(
src_private_blocks
[
0
].
second
-
src_private_blocks
[
0
].
first
)
==
buff_size
){
//simple shared malloc ... return.
if
(
src_private_blocks
.
size
()
==
0
){
//simple shared malloc ... return.
XBT_VERB
(
"Sender is shared. Let's ignore it."
);
smpi_cleanup_comm_after_copy
(
comm
,
buff
);
return
;
...
...
@@ -191,7 +191,7 @@ void smpi_comm_copy_buffer_callback(simgrid::kernel::activity::CommImpl* comm, v
}
if
(
smpi_is_shared
((
char
*
)
comm
->
dst_buff_
,
dst_private_blocks
,
&
dst_offset
))
{
dst_private_blocks
=
shift_and_frame_private_blocks
(
dst_private_blocks
,
dst_offset
,
buff_size
);
if
(
src_private_blocks
.
size
()
==
1
&&
(
src_private_blocks
[
0
].
second
-
src_private_blocks
[
0
].
first
)
==
buff_size
){
//simple shared malloc ... return.
if
(
dst_private_blocks
.
size
()
==
0
){
//simple shared malloc ... return.
XBT_VERB
(
"Receiver is shared. Let's ignore it."
);
smpi_cleanup_comm_after_copy
(
comm
,
buff
);
return
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment