Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • F Flatisfy
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 26
    • Issues 26
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Phyks
  • Flatisfy
  • Merge requests
  • !9

Optimize photo comparisons

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Phyks requested to merge better-dedup into master Jun 18, 2017
  • Overview 11
  • Commits 1
  • Pipelines 0
  • Changes 4

This commit actually does 3 things and might be a bit controversial:

  • it introduces a way to test performance of a given function by adding a decorator factory for measuring performance.
  • it introduces a photos cache, to prevent useless network requests to fetch pictures (this locally improved the 3rd pass duration from 570 seconds to 70 seconds for my search).
  • it decides that two real estate ads are the same if they either have less than 3 pics and they're all the same, or at least 3 common pics. I don't have data backup this up, but it seemed to work great in my case.

Happy to split this in three smaller commits and/or drop changes that are too controversial to be upstreamed.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: better-dedup