Flatisfy merge requestshttps://framagit.org/phyks/Flatisfy/-/merge_requests2017-06-14T09:08:21Zhttps://framagit.org/phyks/Flatisfy/-/merge_requests/1Fixes #55: Handle ValueError when fetching detailed info about a flat2017-06-14T09:08:21ZPhyksphyks@phyks.meFixes #55: Handle ValueError when fetching detailed info about a flathttps://framagit.org/phyks/Flatisfy/-/merge_requests/2Catch the right error when the constraint type name is not set2017-06-14T08:48:19ZPhyksphyks@phyks.meCatch the right error when the constraint type name is not setWhen running the `python -m flatisfy fetch` line without a config file, an unexpected error triggers, preventing to land in the catch block and show the error message about the missing config. This fixes it.When running the `python -m flatisfy fetch` line without a config file, an unexpected error triggers, preventing to land in the catch block and show the error message about the missing config. This fixes it.https://framagit.org/phyks/Flatisfy/-/merge_requests/3Fix image slider perspective2017-06-29T10:00:54ZPhyksphyks@phyks.meFix image slider perspectiveIn the slider, images are resized in a strange way, with fixed sizes. I think these should just respect the proportions and have (relative to the parent) maximum constraints. This works fine for me, but my CSS foo is very bad, so any com...In the slider, images are resized in a strange way, with fixed sizes. I think these should just respect the proportions and have (relative to the parent) maximum constraints. This works fine for me, but my CSS foo is very bad, so any comment will be appreciated :)https://framagit.org/phyks/Flatisfy/-/merge_requests/4WIP: More responsive layout2017-11-27T09:42:49ZPhyksphyks@phyks.meWIP: More responsive layoutSee #52.See #52.https://framagit.org/phyks/Flatisfy/-/merge_requests/5Add support for Foncia backend from Weboob2017-06-26T11:33:21ZPhyksphyks@phyks.meAdd support for Foncia backend from WeboobThis is a WIP, waiting for [this MR](https://git.weboob.org/weboob/devel/merge_requests/38) to get merged upstream.This is a WIP, waiting for [this MR](https://git.weboob.org/weboob/devel/merge_requests/38) to get merged upstream.https://framagit.org/phyks/Flatisfy/-/merge_requests/6Add support for Tcl data2017-06-19T10:04:15ZPhyksphyks@phyks.meAdd support for Tcl data/cc @bnjbvr
This closes #58.
Note: With this commit, your db needs to be migrated, but I did not yet write the migration. Basically, you need to manually create the tables for https://git.phyks.me/Phyks/flatisfy/blob/tcl/flatisfy/m.../cc @bnjbvr
This closes #58.
Note: With this commit, your db needs to be migrated, but I did not yet write the migration. Basically, you need to manually create the tables for https://git.phyks.me/Phyks/flatisfy/blob/tcl/flatisfy/models/postal_code.py and https://git.phyks.me/Phyks/flatisfy/blob/tcl/flatisfy/models/public_transport.py.https://framagit.org/phyks/Flatisfy/-/merge_requests/7Multiple constraints in config2017-06-19T09:14:39ZPhyksphyks@phyks.meMultiple constraints in configCloses issue #61.
Should be merged after !6.Closes issue #61.
Should be merged after !6.https://framagit.org/phyks/Flatisfy/-/merge_requests/8Display cost per square meter2017-07-11T13:08:44ZPhyksphyks@phyks.meDisplay cost per square meterThis is much useful when looking for a flat to buy; not sure of the value for rents, although I was happy to see it when I was looking for a rent in Paris, just to know if it was above/below the average values.This is much useful when looking for a flat to buy; not sure of the value for rents, although I was happy to see it when I was looking for a rent in Paris, just to know if it was above/below the average values.v0.1https://framagit.org/phyks/Flatisfy/-/merge_requests/9Optimize photo comparisons2017-07-11T13:09:57ZPhyksphyks@phyks.meOptimize photo comparisonsThis commit actually does 3 things and might be a bit controversial:
- it introduces a way to test performance of a given function by adding a decorator factory for measuring performance.
- it introduces a photos cache, to prevent usele...This commit actually does 3 things and might be a bit controversial:
- it introduces a way to test performance of a given function by adding a decorator factory for measuring performance.
- it introduces a photos cache, to prevent useless network requests to fetch pictures (this locally improved the 3rd pass duration from 570 seconds to 70 seconds for my search).
- it decides that two real estate ads are the same if they either have less than 3 pics and they're all the same, or at least 3 common pics. I don't have data backup this up, but it seemed to work great in my case.
Happy to split this in three smaller commits and/or drop changes that are too controversial to be upstreamed.v0.1https://framagit.org/phyks/Flatisfy/-/merge_requests/10Multiple constraints in config and Tcl data2017-06-19T14:12:20ZPhyksphyks@phyks.meMultiple constraints in config and Tcl dataI messed up with my MRs, and merged them too soon. Multiple constraints in config is fine.
Tcl data has some issues, see https://git.phyks.me/Phyks/flatisfy/merge_requests/6.
See https://git.phyks.me/Phyks/flatisfy/merge_requests/6 and...I messed up with my MRs, and merged them too soon. Multiple constraints in config is fine.
Tcl data has some issues, see https://git.phyks.me/Phyks/flatisfy/merge_requests/6.
See https://git.phyks.me/Phyks/flatisfy/merge_requests/6 and https://git.phyks.me/Phyks/flatisfy/merge_requests/7.https://framagit.org/phyks/Flatisfy/-/merge_requests/11Fix image slider perspective2017-06-29T10:02:16ZPhyksphyks@phyks.meFix image slider perspective@Phyks, can you have a look please?@Phyks, can you have a look please?https://framagit.org/phyks/Flatisfy/-/merge_requests/12Adds basic email notifications when new flats have been found (fixes #47)2017-07-06T13:07:36ZPhyksphyks@phyks.meAdds basic email notifications when new flats have been found (fixes #47)@Phyks, mind to have a look? Many things are poorly coded in this MR (no translations, raw handling of emails), but this was enough for me to work :)
Follow-up items:
- the emails get a pretty bad spam score because they don't have a Da...@Phyks, mind to have a look? Many things are poorly coded in this MR (no translations, raw handling of emails), but this was enough for me to work :)
Follow-up items:
- the emails get a pretty bad spam score because they don't have a Date header...
- ... as well as a MessageId header.
- we could probably do some better display in the HTML case
- also, maybe we don't want emails on notifications, but email every N hours if there's at least one new flat, or an email every time there are at least N new flats or M hours have passed.https://framagit.org/phyks/Flatisfy/-/merge_requests/13Use a single common data source for public transports stops2017-12-04T15:18:51ZPhyksphyks@phyks.meUse a single common data source for public transports stopsNow makes use of Navitia opendata dumps to cover France. Fixes #65.Now makes use of Navitia opendata dumps to cover France. Fixes #65.https://framagit.org/phyks/Flatisfy/-/merge_requests/14Small fixes/improvements to getting started documentation2017-12-29T21:51:03ZPhyksphyks@phyks.meSmall fixes/improvements to getting started documentationhttps://framagit.org/phyks/Flatisfy/-/merge_requests/15Allow to define the threshold between a housing and a station2017-12-30T13:25:27ZPhyksphyks@phyks.meAllow to define the threshold between a housing and a stationFix #101.Fix #101.https://framagit.org/phyks/Flatisfy/-/merge_requests/16Fix a bug when throwing an exception with unicode characters from2018-01-06T10:05:50ZPhyksphyks@phyks.meFix a bug when throwing an exception with unicode characters fromWeboob.
As reported by @nicofrand.Weboob.
As reported by @nicofrand.https://framagit.org/phyks/Flatisfy/-/merge_requests/17Add unit tests2018-01-17T12:22:20ZNicolas Frandeboeufmail@nicofrand.euAdd unit testsThe test with real values actually fails because of photos.
Should I keep it so we can try to solve it ?
What do you think of those tests ? If moving the duplicate score calculation outside of the `deep_detect` function is OK, more ...The test with real values actually fails because of photos.
Should I keep it so we can try to solve it ?
What do you think of those tests ? If moving the duplicate score calculation outside of the `deep_detect` function is OK, more tests could be added later without too much hasslehttps://framagit.org/phyks/Flatisfy/-/merge_requests/18Fix roman numbers2018-01-18T13:17:57ZNicolas Frandeboeufmail@nicofrand.euFix roman numbers* [x] Fix roman numbers convertion
* [x] Fix huge errors in tests -_-* [x] Fix roman numbers convertion
* [x] Fix huge errors in tests -_-https://framagit.org/phyks/Flatisfy/-/merge_requests/19Improve cities fuzzy matching2018-01-19T23:13:44ZPhyksphyks@phyks.meImprove cities fuzzy matching* Convert arabic numerals to roman ones in fuzzy comparison, to ensure
there is no more discrepancies between "Paris 20" and "Paris XX" for
instance. Fix #112 and improve on top of #110.
* Improve handling of opendata postal codes (no mo...* Convert arabic numerals to roman ones in fuzzy comparison, to ensure
there is no more discrepancies between "Paris 20" and "Paris XX" for
instance. Fix #112 and improve on top of #110.
* Improve handling of opendata postal codes (no more duplicates, better
capitalization).
Note: You should `pip install -r requirements.txt` and rebuild the
database (`python -m flatisfy build-data --config config.json`) after
this commit.
Thanks @nicofrand for building the basic blocks for this!Nicolas Frandeboeufmail@nicofrand.euNicolas Frandeboeufmail@nicofrand.euhttps://framagit.org/phyks/Flatisfy/-/merge_requests/20Move config constraints into db2021-03-14T17:02:06ZPhyksphyks@phyks.meMove config constraints into dbPhyksphyks@phyks.mePhyksphyks@phyks.me