Skip to content

Small fixes

Ghost User requested to merge development into staging

Goals

Fix validations and error messages

  • fix password_confirmation missing validation
  • fix and/or translate error messages

Introduce empty search

  • permit empty search
  • empty search displays all composts

Misc

  • add seed back to Heroku
  • display messages in the right order
  • fix navbar unread messages display
  • move profile enhancement to homepage
  • draft Readme
  • cleanup a little - unused views

Changes

  • app/controllers/composts_controller.rb : removed profile enhancement callback
  • app/controllers/results_controller.rb
    • removed empty search restrictions
    • added profile enhancement callback
  • app/models/result.rb : added empty search logic
  • config/application.rb : linked devise french locale strings
  • config/locales/devise.fr.yml : devise french locale
  • app/models/compost.rb and app/models/user.rb : updated validations and error messages
  • app/views/composts/_form.html.erb and app/views/users/_form.html.erb : updated error messages display
  • app/views/devise/shared/_error_messages.html.erb : updated error messages display
  • app/views/application/_navbartype.html.erb : updated unread messages notification
  • Procfile : added seed to release phase
  • README.md : first draft
  • app/controllers/messages_controller.rb : sorted messages for display

Tests

  • signup and registration edit are no longer possible without password confirmation : RESULT
  • CRUD success and failures result in beautiful error messages : RESULT
    • for registration creation, edition and deletion : RESULT
    • for compost creation, edition and deletion : RESULT
    • for contribution creation, acceptance and rejection : RESULT
    • for timeslot creation and deletion : RESULT
  • empty search is possible : RESULT
    • empty search returns full composts list : RESULT
  • new messages are displayed at the bottom of the list : RESULT
  • profile enhancement alert is displayed on homepage if profile is incomplete : RESULT
Edited by Heroponne

Merge request reports