Commit 23787730 authored by Jean-Francois Dockes's avatar Jean-Francois Dockes
Browse files

Change enablel16 config default from false to true as current mpd versions handle it well

parent 681e9a0e
......@@ -129,8 +129,11 @@ HTTP server). Default: '$pkgdatadir/presentation.html'.
[[enablel16]]
enablel16:: Advertise L16 format support L16 is a raw linear 16 bits audio stream and the source of many
issues because it does not include identifying information. It is
disabled by default, only enable it if you know that you need it.
issues because it does not include identifying information. It used to be
disabled by default, because of an mpd bug resulting in a lot of noise. It's
now on by default, but can still be disabled if needed. It seems that it
sometimes interfers badly with the win10 "cast to device" feature, so you may
try to turn it off if you have problems with this.
=== MPD parameters
......
......@@ -160,7 +160,7 @@ string g_cachedir("/var/cache/upmpdcli");
string g_configfilename;
ConfSimple *g_config;
ConfSimple *g_state;
bool g_enableL16 = false;
bool g_enableL16 = true;
bool g_lumincompat = false;
static void onsig(int)
......@@ -655,9 +655,9 @@ int main(int argc, char *argv[])
// reason, with very bad results. So for the future (new in
// 1.5), only enable it if it's explicitely required by the
// config.
bool confl16{false};
bool confl16{true};
if (g_config) {
confl16 = g_config->getBool("enablel16", false);
confl16 = g_config->getBool("enablel16", true);
}
g_enableL16 = g_enableL16 && confl16;
}
......
......@@ -56,7 +56,7 @@
# Path to the presentation HTML document
#presentationhtml = /usr/share/upmpdcli/presentation.html
# Advertise L16 format support
#enablel16 = false
#enablel16 = true
# MPD parameters
......
......@@ -152,10 +152,13 @@
# <var name="enablel16" type="bool">
# <brief>Advertise L16 format support</brief>
# <descr>L16 is a raw linear 16 bits audio stream and the source of many
# issues because it does not include identifying information. It is
# disabled by default, only enable it if you know that you need it.</descr>
# issues because it does not include identifying information. It used to be
# disabled by default, because of an mpd bug resulting in a lot of noise. It's
# now on by default, but can still be disabled if needed. It seems that it
# sometimes interfers badly with the win10 "cast to device" feature, so you may
# try to turn it off if you have problems with this.</descr>
# </var>
#enablel16 = false
#enablel16 = true
# <grouptitle>MPD parameters</grouptitle>
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment