[meta] Rename All The Fields!
Here are suggestions for renamings that I'd like to do before moving to SQL (to not make the SQL MR too big). Note that each renaming might imply other renamings, e.g. for functions touching these fields, in the client, etc.
Access
-
Access.bank
toAccess.vendorId
Account
-
Account.bank
toAccount.vendorId
(or remove the field as suggested, since it's reachable from the access) -
Account.bankAccess
toAccount.accessId
-
Account.accountNumber
toAccount.vendorAccountId
(check if this behaves as an id for other models as commented?) (could even bevendorId
if we removed the need for the current vendorId) -
Account.initialAmount
toAccount.initialBalance
-
Account.lastChecked
toAccount.lastCheckDate
-
Account.title
toAccount.label
Category
-
Category.title
toCategory.label
Setting
-
Setting.name
toSetting.key
-
rename all the keys to snake_case
Transaction
-
Operation.title
toOperation.label
-
Operation.raw
toOperation.rawLabel
-
Operation.dateImport
toOperation.importDate
-
Operation
toTransaction
It'd be nice if we could address each bullet point with a separate commit, maybe doing so in separate MRs even.
I wonder if we should rename booleans too with a systemic rule to prefix them by "is", to make it ultra obvious they're boolean values.
If you have better ideas for any of these names, or there's any other names that would need a renaming according to you, please add a comment so we can discuss it.