1. 24 Aug, 2019 1 commit
    • rgaudin's avatar
      Various fixes for windows/py3.4 · 070560d6
      rgaudin authored
      using mkdtemp as NamedTemporaryFile can't be reopened on windows
      saving files with UTF-8 encoding
      removing commas after **kwargs
      removing f-strings
      using universal_newlines instead of text with subprocess
      070560d6
  2. 02 Dec, 2018 1 commit
  3. 29 Nov, 2018 2 commits
  4. 26 Nov, 2018 2 commits
  5. 21 Nov, 2018 1 commit
  6. 13 Nov, 2018 1 commit
    • rgaudin's avatar
      SD-card partition check enhancement · 500beda9
      rgaudin authored
      - Moved SD-card partition check back to button action
      - SD-card partition check timesout after 10s to prevent some freezes
      500beda9
  7. 11 Nov, 2018 2 commits
  8. 07 Nov, 2018 1 commit
  9. 29 Oct, 2018 1 commit
  10. 27 Oct, 2018 1 commit
  11. 26 Oct, 2018 1 commit
    • rgaudin's avatar
      Windows-specific fixes: · 6eefb4ef
      rgaudin authored
      - tempfile needs delete=False in catalogs download.
      - windows is already in admin mode
      - device path for etcher-cli is eventually identical to others
      - build_zim_store() can't be called from within the thread (freezes UI forever)
      6eefb4ef
  12. 25 Oct, 2018 1 commit
    • rgaudin's avatar
      Fixed #220: using Etcher-cli to write and verify SD-card · 479ad4fb
      rgaudin authored
      - Using v1.4.5 on Linux and macOS
      - Using 1.1.2 on Windows (later versions are buggy)
      - etcher-cli used with auto-check and auto-unmount options
      - etcher-cli requires sudo on macOS and linux (in win32, we already run as admin)
        so password is asked at writing stage
      - no more password on macOS and linux to change SD card device mode on start
        linux still ask for loop device mode change though
      479ad4fb
  13. 21 Sep, 2018 2 commits
  14. 11 Sep, 2018 2 commits
  15. 06 Sep, 2018 1 commit
  16. 31 Aug, 2018 1 commit
    • rgaudin's avatar
      Issue #214: Improve SD card writing · c892639b
      rgaudin authored
      - add a delay after diskpart to prevent Bad file descriptor error
      - speed up process by writing chunks of 25MiB
      - properly close device and image on error
      - additional logging
      - fixed SD challenge offset
      - copy is properly cancellable
      - dont consider failed-to-write as a complete failure (use success image name)
      - in case of failure to write, invite user to use Etcher via File menu entry
      c892639b
  17. 20 Aug, 2018 1 commit
  18. 31 Jul, 2018 1 commit
    • rgaudin's avatar
      Loop device permission (mode) change on Linux · 7f65944e
      rgaudin authored
      On Linux, loop-device setup, mount, unmount and removal is done in userspace thanks to udisks2.
      Now that we format the third partition on the host (before copying large files into it),
      we need to have the permission to mkfs on the loop device.
      
      At this step, the following now applies:
      
      	check wether we can write on loop device (Sys requirements advises user to be member of the `disk` group)
      	change mode if we can't (requesting elevation)
      	restore mode after we've formatted (requesting elevation – usually before previous elevation expiration)
      
      Additionaly, to prevent unexpected request for elevation at the format step (usually 30-90mn into the process), on startup:
      	attempt to guess loop device path on start. This might fail or be wrong (another app uses the guessed loop before the format step) but that should be rare.
      	change mode of guessed loop device (along with SD card, so a single request right on startup)
      	restore mode at end of process (along with SD card)
      
      	if we could not properly guess, elevation will be requested at format step.
      
      Also enforcing usage of logger everywhere (subprocess calls for mount) as missing logger leads to painful diagnostics
      7f65944e
  19. 27 Jun, 2018 1 commit
    • rgaudin's avatar
      updated subprocess helper · 946b8c83
      rgaudin authored
      	created a new, more flexible helper:
      		- logger is optionnal
      		- check is optionnal
      		- can optionnaly decode output to string
      		- can optionnaly run the command as admin
      	former subprocess_pretty_check_call now uses the new helper
      946b8c83
  20. 30 Jun, 2017 2 commits