1. 25 May, 2016 1 commit
  2. 24 May, 2016 1 commit
  3. 17 May, 2016 2 commits
  4. 10 May, 2016 1 commit
  5. 26 Apr, 2016 1 commit
  6. 25 Apr, 2016 1 commit
  7. 13 Apr, 2016 1 commit
  8. 11 Apr, 2016 1 commit
    • redmatrix's avatar
      when setting the session handler as an object using the auto register shutdown... · 0fe49572
      redmatrix authored
      when setting the session handler as an object using the auto register shutdown flag, explicitly calling session_write_close() should no longer be required. It shouldn't cause any issues if it is called twice, but the session driver interface has been known to sometimes act in unexpected ways and there are lots of "subtleties" which can often be difficult to debug. The mentioned flag implies PHP 5.4 minimum but I believe we require that anyway.
      0fe49572
  9. 08 Apr, 2016 1 commit
  10. 06 Apr, 2016 1 commit
  11. 04 Apr, 2016 1 commit
  12. 01 Apr, 2016 2 commits
  13. 31 Mar, 2016 2 commits
  14. 24 Feb, 2016 1 commit
  15. 20 Feb, 2016 1 commit
  16. 05 Feb, 2016 1 commit
  17. 31 Jan, 2016 1 commit
  18. 18 Jan, 2016 1 commit
  19. 12 Jan, 2016 1 commit
    • redmatrix's avatar
      'auto channel creation' - if the corresponding config variable is set, create... · baedd253
      redmatrix authored
      'auto channel creation' - if the corresponding config variable is set, create a channel when an account is created.
      Plugins can provide the necessary channel details (probably from an extended registration form). If no details are provided, a social (mostly public) channel will be created using the LHS of the email address and you will be directed to your channel page (unless email verification is required, in which case this step will be delayed until successful validation and login). If the reddress is already assigned a random name(1000-9999) reddress will be assigned.
      baedd253
  20. 20 Nov, 2015 2 commits
  21. 16 Jul, 2015 1 commit
  22. 05 Jul, 2015 1 commit
  23. 26 Jun, 2015 1 commit
  24. 24 May, 2015 1 commit
  25. 05 May, 2015 1 commit
  26. 03 Mar, 2015 1 commit
  27. 23 Feb, 2015 1 commit
  28. 29 Jan, 2015 1 commit
  29. 13 Nov, 2014 1 commit
    • Habeas Codice's avatar
      PostgreSQL support initial commit · 1a5a5c7e
      Habeas Codice authored
      There were 11 main types of changes:
      - UPDATE's and DELETE's sometimes had LIMIT 1 at the end of them. This is not only non-compliant but
      it would certainly not do what whoever wrote it thought it would. It is likely this mistake was just
      copied from Friendica. All of these instances, the LIMIT 1 was simply removed.
      - Bitwise operations (and even some non-zero int checks) erroneously rely on MySQL implicit
      integer-boolean conversion in the WHERE clauses. This is non-compliant (and bad programming practice
      to boot). Proper explicit boolean conversions were added. New queries should use proper conventions.
      - MySQL has a different operator for bitwise XOR than postgres. Rather than add yet another dba_
      func, I converted them to "& ~" ("AND NOT") when turning off, and "|" ("OR") when turning on. There
      were no true toggles (XOR). New queries should refrain from using XOR when not necessary.
      - There are several fields which the schema has marked as NOT NULL, but the inserts don't specify
      them. The reason this works is because mysql totally ignores the constraint and adds an empty text
      default automatically. Again, non-compliant, obviously. In these cases a default of empty text was
      added.
      - Several statements rely on a non-standard MySQL feature
      (http://dev.mysql.com/doc/refman/5.5/en/group-by-handling.html). These queries can all be rewritten
      to be standards compliant. Interestingly enough, the newly rewritten standards compliant queries run
      a zillion times faster, even on MySQL.
      - A couple of function/operator name translations were needed (RAND/RANDOM, GROUP_CONCAT/STRING_AGG,
      UTC_NOW, REGEXP/~, ^/#) -- assist functions added in the dba_
      - INTERVALs: postgres requires quotes around the value, mysql requires that there are not quotes
      around the value -- assist functions added in the dba_
      - NULL_DATE's -- Postgres does not allow the invalid date '0000-00-00 00:00:00' (there is no such
      thing as year 0 or month 0 or day 0). We use '0001-01-01 00:00:00' for postgres. Conversions are
      handled in Zot/item packets automagically by quoting all dates with dbescdate().
      - char(##) specifications in the schema creates fields with blank spaces that aren't trimmed in the
      code. MySQL apparently treats char(##) as varchar(##), again, non-compliant. Since postgres works
      better with text fields anyway, this ball of bugs was simply side-stepped by using 'text' datatype
      for all text fields in the postgres schema. varchar was used in a couple of places where it actually
      seemed appropriate (size constraint), but without rigorously vetting that all of the PHP code
      actually validates data, new bugs might come out from under the rug.
      - postgres doesn't store nul bytes and a few other non-printables in text fields, even when quoted.
      bytea fields were used when storing binary data (photo.data, attach.data). A new dbescbin() function
      was added to handle this transparently.
      - postgres does not support LIMIT #,# syntax. All databases support LIMIT # OFFSET # syntax.
      Statements were updated to be standard.
      
      These changes require corresponding changes in the coding standards. Please review those before
      adding any code going forward.
      
      Still on my TODO list:
      - remove quotes from non-reserved identifiers and make reserved identifiers use dba func for quoting
      - Rewrite search queries for better results (both MySQL and Postgres)
      1a5a5c7e
  30. 04 Nov, 2014 1 commit
  31. 31 Oct, 2014 1 commit
  32. 20 Oct, 2014 1 commit
  33. 30 Sep, 2014 1 commit
  34. 23 May, 2014 1 commit
  35. 13 May, 2014 1 commit
  36. 09 May, 2014 1 commit