Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Lufi Lufi
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 60
    • Issues 60
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 8
    • Merge requests 8
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Fiat Tux
  • Hat softwares
  • LufiLufi
  • Merge requests
  • !78
The source project of this merge request has been removed.

`Notification not defined` fix (should fix #192, may fix #224)

Merged Paco Pomme requested to merge (removed):master into development Jan 13, 2021
  • Overview 0
  • Changes 1

The #192 (closed) problem has been encountered on Debian 8/ Firefox 60.2.2esr (64 bits) by an user of Picasoft's Lufi instance.

This line was in the logs : ReferenceError: Notification is not defined[Learn More] lufi-notifications.js:19:9

This issue in another project suggests a fix for this. I tried this in the FF console and it indeed prevented the JS error.

⚠ I didn't launch a localhost instance to e2e test this fix.

Is it ok to merge this ?

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: master